add sfx, more ergonomic keys (in my opinion), fixed (probably) piece swapping #1

Closed
electron271 wants to merge 2 commits from electron271/just-plain-tetris:main into main
First-time contributor

sorry if the code is crap i extremely rarely use c/c++

sorry if the code is crap i extremely rarely use c/c++
electron271 added 1 commit 2024-02-20 05:47:27 +00:00
Author
First-time contributor

tomorrow i will likely implement a sort of shadow of where the piece will fall

tomorrow i will likely implement a sort of shadow of where the piece will fall
Owner

hey thanks for your hard work!

the controls of the original example game were using the arrow keys and i changed them to WASD because i find that better. i might end up just allowing either tbh.

i don't really care about sound either (deaf) but i might as well merge it in!

what was broken about piece swapping?

also the shadow is a cool idea, that's one thing i consider a "standard feature".

hey thanks for your hard work! the controls of the original example game were using the arrow keys and i changed them to WASD because i find that better. i might end up just allowing either tbh. i don't really care about sound either (deaf) but i might as well merge it in! what was broken about piece swapping? also the shadow is a cool idea, that's one thing i consider a "standard feature".
Author
First-time contributor

when you swap a piece it would go back to the top, in this version (if i did it right) it stays in the original position of the piece

will test a bit more also to see if its glitchy at all

but yeah my reasoning for the new controls is so your left hand can be on s and r and right hand on arrow keys, but i may make it configurable (feel free to change the controls back)

when you swap a piece it would go back to the top, in this version (if i did it right) it stays in the original position of the piece will test a bit more also to see if its glitchy at all but yeah my reasoning for the new controls is so your left hand can be on s and r and right hand on arrow keys, but i may make it configurable (feel free to change the controls back)
Author
First-time contributor

ok yeah this type of swapping can be a bit glitchy, will try to fix

ok yeah this type of swapping can be a bit glitchy, will try to fix
electron271 added 1 commit 2024-02-20 16:46:36 +00:00
Author
First-time contributor

latest commit should fix

latest commit should fix
Owner

when you swap a piece it would go back to the top

that's intended behavior. i think it's common to use the swap feature to buy yourself more time.

> when you swap a piece it would go back to the top that's intended behavior. i think it's common to use the swap feature to buy yourself more time.
reese closed this pull request 2024-02-20 18:24:58 +00:00
Author
First-time contributor

yeah fair that was what i used it for

can revert laterish

yeah fair that was what i used it for can revert laterish

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: reese/just-plain-tetris#1
No description provided.