WIP: wishlist improvements #4

Draft
reese wants to merge 2 commits from reese/nekobot:shopping into main
Owner

i wanted to add functionality to the wishlist where you can remove items by number, but i found it is kind of contrived to do that in shell so i rewrote it in the best scripting language i know for that sort of thing: python 🐍

it has other changes:

  • strips blank lines
  • removed clear command. i think if someone really wants to clear it they can do it by hand.

standing issues

  • some matrix clients already show line numbers next to code blocks. in element it is optional. i forgot that feature existed until just now. if you have line numbers turned on then the script's numbers are redundant and possibly off by 1 which could lead to someone deleting the wrong item.
  • it throws an error when the list file doesn't exist- you have to create it first.
  • it should probably be tested by at least 1 other human before it goes live.
  • wishlist still exists. should shopping replace it? i prefer the name shopping because it fits the purpose better.
i wanted to add functionality to the wishlist where you can remove items by number, but i found it is kind of contrived to do that in shell so i rewrote it in the best scripting language i know for that sort of thing: python 🐍 it has other changes: - strips blank lines - removed `clear` command. i think if someone *really* wants to clear it they can do it by hand. #### standing issues - some matrix clients already show line numbers next to code blocks. in element it is optional. i forgot that feature existed until just now. if you have line numbers turned on then the script's numbers are redundant and possibly off by 1 which could lead to someone deleting the wrong item. - it throws an error when the list file doesn't exist- you have to create it first. - it should probably be tested by at least 1 other human before it goes live. - `wishlist` still exists. should `shopping` replace it? i prefer the name `shopping` because it fits the purpose better.
reese added 1 commit 2023-06-29 19:10:20 +00:00
reese added 1 commit 2023-06-29 19:12:41 +00:00
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b reese-shopping main
git pull shopping

Step 2:

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff reese-shopping
git push origin main
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cyberia/nekobot#4
No description provided.