cyberia/nekobot
8
2
Fork 1
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

WIP: wishlist improvements #4

Draft
reese wants to merge 2 commits from reese/nekobot:shopping into main
pull from: reese/nekobot:shopping
merge into: cyberia:main
Conversation 0 Commits 2 Files changed 1 +76
reese commented 2023-06-29 19:10:19 +00:00
Owner
Copy link

i wanted to add functionality to the wishlist where you can remove items by number, but i found it is kind of contrived to do that in shell so i rewrote it in the best scripting language i know for that sort of thing: python 🐍

it has other changes:

  • strips blank lines
  • removed clear command. i think if someone really wants to clear it they can do it by hand.

standing issues

  • some matrix clients already show line numbers next to code blocks. in element it is optional. i forgot that feature existed until just now. if you have line numbers turned on then the script's numbers are redundant and possibly off by 1 which could lead to someone deleting the wrong item.
  • it throws an error when the list file doesn't exist- you have to create it first.
  • it should probably be tested by at least 1 other human before it goes live.
  • wishlist still exists. should shopping replace it? i prefer the name shopping because it fits the purpose better.
i wanted to add functionality to the wishlist where you can remove items by number, but i found it is kind of contrived to do that in shell so i rewrote it in the best scripting language i know for that sort of thing: python 🐍 it has other changes: - strips blank lines - removed `clear` command. i think if someone *really* wants to clear it they can do it by hand. #### standing issues - some matrix clients already show line numbers next to code blocks. in element it is optional. i forgot that feature existed until just now. if you have line numbers turned on then the script's numbers are redundant and possibly off by 1 which could lead to someone deleting the wrong item. - it throws an error when the list file doesn't exist- you have to create it first. - it should probably be tested by at least 1 other human before it goes live. - `wishlist` still exists. should `shopping` replace it? i prefer the name `shopping` because it fits the purpose better.
reese added 1 commit 2023-06-29 19:10:20 +00:00
reese added 1 commit 2023-06-29 19:12:41 +00:00
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u shopping:reese-shopping
git checkout reese-shopping

Merge

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff reese-shopping
git checkout main
git merge --ff-only reese-shopping
git checkout reese-shopping
git rebase main
git checkout main
git merge --no-ff reese-shopping
git checkout main
git merge --squash reese-shopping
git checkout main
git merge --ff-only reese-shopping
git checkout main
git merge reese-shopping
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: cyberia/nekobot#4
No description provided.
Delete branch "reese/nekobot:shopping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?